Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9136: [ALW] UI language issue vs content language #1392

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Nov 14, 2024

🎫 Issue IBX-9136

Related PRs:

Description:

For QA:

Besides test ALW, this PR needs tests language filter in UDW and Image Picker

Documentation:

@bogusez bogusez force-pushed the IBX-9136-ALW-UI-language-issue-vs-content-language branch from c53e98a to 00577a6 Compare November 22, 2024 11:38
@bogusez bogusez self-assigned this Nov 22, 2024
@bogusez bogusez force-pushed the IBX-9136-ALW-UI-language-issue-vs-content-language branch from 00577a6 to 0f4e18d Compare November 26, 2024 07:05
@bogusez
Copy link
Contributor

bogusez commented Nov 26, 2024

@lucasOsti I cannot duplicate image files with different translation than english, e.g. I added in back office an image file with polish translation and when trying duplicate it on ALW side an error occurs:

Screenshot 2024-11-26 at 12 04 25

Edit: Interesting thing is that when I get this error and refresh the page, the duplicated image file is available on the image file list (ALW)

@bogusez
Copy link
Contributor

bogusez commented Nov 27, 2024

@lucasOsti

DXP side:

when image file is duplicated with enabled filtering by translation, after duplication user is redirected to main folder Media and filter is cleared.

Screen.Recording.2024-11-27.at.12.35.25.mov

deleting the image with enabled translation filter does not work, at the backend side the request is triggered but on UI side nothing happens.

Screen.Recording.2024-11-27.at.12.39.14.mov

@lucasOsti
Copy link
Contributor Author

@lucasOsti I cannot duplicate image files with different translation than english, e.g. I added in back office an image file with polish translation and when trying duplicate it on ALW side an error occurs:

Screenshot 2024-11-26 at 12 04 25 Edit: Interesting thing is that when I get this error and refresh the page, the duplicated image file is available on the image file list (ALW)

After the conversation, Damian Korostyński and I agreed that we would change the method of duplication. Previously, the user has the option to edit fields before the duplication operation. We are currently creating a 1:1 duplicate

@bogusez bogusez force-pushed the IBX-9136-ALW-UI-language-issue-vs-content-language branch from 0f4e18d to 1000ab7 Compare November 29, 2024 13:03
@bogusez
Copy link
Contributor

bogusez commented Dec 4, 2024

@lucasOsti I found more issues related to language filter.

Scenario 1:

  • Open image picker instance
  • Expand translation filter and select language
  • Filter image files by selected language
  • Select filtered image file
  • Edit image file (chage some data on edit image filter form)
  • Publish

Result: After reloading page user is redirected to media folder (main folder in content tree structure) and translation filter is cleared.

Scenario 2:

  • Open image picker instance
  • Expand translation filter and select language
  • Filter image files by selected language
  • Upload an image file (select from computer directory)

Result: After reloading page user is redirected to media folder (main folder in content tree structure) and translation filter is cleared.

@bogusez
Copy link
Contributor

bogusez commented Dec 5, 2024

@lucasOsti on solr and elastic search the function 'Upload file' clear all filters

@lucasOsti
Copy link
Contributor Author

@bogusez after talks with the frontend team, we came to the conclusion that we will not remember the state of filters for actions upload, edit, duplicate because it is not a critical point of the application and it would cause redundancy of stored data and unnecessary complication of the code.

@bogusez
Copy link
Contributor

bogusez commented Dec 6, 2024

@bogusez after talks with the frontend team, we came to the conclusion that we will not remember the state of filters for actions upload, edit, duplicate because it is not a critical point of the application and it would cause redundancy of stored data and unnecessary complication of the code.

Thank you for the information

@bogusez bogusez force-pushed the IBX-9136-ALW-UI-language-issue-vs-content-language branch from 1000ab7 to fde93e5 Compare December 9, 2024 06:51
@bogusez bogusez force-pushed the IBX-9136-ALW-UI-language-issue-vs-content-language branch from fde93e5 to 12fc6e5 Compare December 9, 2024 13:18
Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link
Contributor

@bogusez bogusez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved

Tested on DXP using legacy, ES and solr search engines.
Tested on ALW

@dew326 dew326 merged commit 81009e5 into 4.6 Dec 10, 2024
29 checks passed
@dew326 dew326 deleted the IBX-9136-ALW-UI-language-issue-vs-content-language branch December 10, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants