Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7558: Added posibiity to close navbar menu #1120

Merged
merged 44 commits into from
Jul 19, 2024
Merged

IBX-7558: Added posibiity to close navbar menu #1120

merged 44 commits into from
Jul 19, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Jan 17, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7558
Type bug
Target version v4.6
BC breaks no
Doc needed no

Added posibiity to close navbar menu

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i requested a review from lucasOsti January 19, 2024 10:15
@bogusez bogusez self-assigned this Jan 26, 2024
@Gengar-i Gengar-i force-pushed the ibx-7558-navbar-close branch from 0b03fd7 to a3f05b7 Compare January 26, 2024 08:10
@bogusez
Copy link
Contributor

bogusez commented Jan 26, 2024

@Gengar-i there is a bug, when I close the menu, I cannot open it again
https://recordit.co/TyIpoEwqBR

This was referenced Jan 26, 2024
Closed
Closed
Closed
@bogusez
Copy link
Contributor

bogusez commented Jan 29, 2024 •
edited
Loading

@Gengar-i there is a bug, when I close the menu, I cannot open it again https://recordit.co/TyIpoEwqBR

Update: the problem exist on web browsers as listed below:

  • Opera
  • Brave
  • Edge

On Chrome, Firefox and Safari the feature works properly.

@Gengar-i Gengar-i force-pushed the ibx-7558-navbar-close branch from a3f05b7 to 38c373a Compare January 30, 2024 18:17
@bogusez
Copy link
Contributor

bogusez commented Jan 31, 2024 •
edited
Loading

@Gengar-i the bug fix did not solve the issue. I think the problem might be related also to 'focus mode' functionality. Have a look on vid to see how it behaves right now: https://recordit.co/jtjAQUWpKn

edit: it's not working now on browsers:

  • Chrome
  • Opera
  • Brave

@Gengar-i Gengar-i force-pushed the ibx-7558-navbar-close branch 2 times, most recently from 09a7bfe to 6002092 Compare February 5, 2024 08:12
@Gengar-i Gengar-i force-pushed the ibx-7558-navbar-close branch from 4ef3c7f to 648c19f Compare February 21, 2024 09:59
@Gengar-i Gengar-i changed the base branch from main to 4.6 March 15, 2024 09:03
@bogusez bogusez removed their assignment Mar 21, 2024
@tomaszszopinski
Copy link
Contributor

Green CI build: ibexa/commerce#935

@tomaszszopinski
Copy link
Contributor

Green CI build: https://github.com/ibexa/commerce/actions/runs/9971661327?pr=935

@tomaszszopinski
Copy link
Contributor

tomaszszopinski commented Jul 18, 2024 •
edited
Loading

For QA (what i did here):

  • ive created 2 new steps: goToSubTab and changeSubTab. It is difficult now, because of focusmode, to create universal function for tab & subtab traversal so ive decided to split them.
  • ive split admin-ui jobs into 2 new ones: Oss/headless and Experience/Commerce. Reason for this change is that Oss/headless has old dashboard, and Experience/Commerce has a new one.
  • ive removed AddLocation.feature and SubTreeEditor.feature from Oss/Headless. This will have to have a followup, to add handling of old dashboard.

@tomaszszopinski tomaszszopinski requested a review from a team July 18, 2024 08:33
micszo
micszo approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this over! 💪🏻

I'm ok with the setup changes.

Could you paste the follow-up task also in this PR?

.github/workflows/browser-tests.yaml Outdated Show resolved Hide resolved
@micszo micszo requested a review from a team July 18, 2024 08:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tomaszszopinski
tomaszszopinski approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.6

@tomaszszopinski
Copy link
Contributor

Here is the followup - https://issues.ibexa.co/browse/IBX-8589

@tomaszszopinski tomaszszopinski added QA approved and removed Ready for QA Tests update QA label indicating tests need to be updated labels Jul 19, 2024
@dew326 dew326 merged commit 4186da8 into 4.6 Jul 19, 2024
25 checks passed
@dew326 dew326 deleted the ibx-7558-navbar-close branch July 19, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@micszo micszo micszo approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.