Apply suggestions from code review

Co-authored-by: Łukasz Ostafin <[email protected]>
ibexa · Oct 31, 2023 · 01a5b05 · 01a5b05
1 parent 119c06b
commit 01a5b05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/bundle/Resources/public/js/scripts/admin.search.autocomplete.content.js b/src/bundle/Resources/public/js/scripts/admin.search.autocomplete.content.js
@@ -7,7 +7,7 @@
 
     const { escapeHTML } = ibexa.helpers.text;
     const { highlightText } = ibexa.helpers.highlight;
-    const contentTypeHelper = ibexa.helpers.contentType;
+    const { getContentTypeIconUrl, getContentTypeName } = ibexa.helpers.contentType;
     const autocompleteListNode = globalSearch.querySelector('.ibexa-global-search__autocomplete-list');
     const autocompleteContentTemplateNode = globalSearch.querySelector('.ibexa-global-search__autocomplete-content-template');
     const renderItem = (result, searchText) => {
@@ -28,8 +28,8 @@
         const autocompleteHighlightTemplate = autocompleteListNode.dataset.templateHighlight;
         const renderedTemplate = autocompleteItemTemplate
             .replace('{{ contentName }}', highlightText(searchText, name, autocompleteHighlightTemplate))
-            .replace('{{ iconHref }}', contentTypeHelper.getContentTypeIconUrl(contentTypeIdentifier))
-            .replace('{{ contentTypeName }}', escapeHTML(contentTypeHelper.getContentTypeName(contentTypeIdentifier)))
+            .replace('{{ iconHref }}', getContentTypeIconUrl(contentTypeIdentifier))
+            .replace('{{ contentTypeName }}', escapeHTML(getContentTypeName(contentTypeIdentifier)))
             .replaceAll('{{ contentBreadcrumbs }}', breadcrumb)
             .replace('{{ contentHref }}', Routing.generate('ibexa.content.view', { contentId, locationId }));
 

diff --git a/src/bundle/Resources/public/js/scripts/admin.search.autocomplete.js b/src/bundle/Resources/public/js/scripts/admin.search.autocomplete.js
@@ -52,6 +52,7 @@
             credentials: 'same-origin',
         });
         searchAbortController = new AbortController();
+
         const { signal } = searchAbortController;
 
         fetch(request, { signal })