Skip to content

Commit

Permalink
Revert "Silence completely harmless phpmd warnings"
Browse files Browse the repository at this point in the history
This reverts commit 240bbb7.

Holy molly. phpcs is now complaining about invalid docblock tags when
it reads the phpmd warning suppresion tags. It seems you cannot keep
both happy at the same time. Oh well!

We'll disable the phpmd warning suppresion tags. At least phpmd simply
warns, but doesn't stop the builds.
  • Loading branch information
iarenaza committed Oct 12, 2024
1 parent 240bbb7 commit ea13443
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions classes/text_filter.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ public function filter_stage_pre_format(string $text, array $options): string {
* @param string $text
* @param array $options
* @return string
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function filter_stage_pre_clean(string $text, array $options): string {
return $text;
Expand All @@ -124,8 +122,6 @@ public function filter_stage_pre_clean(string $text, array $options): string {
* @param string $text
* @param array $options
* @return string
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function filter_stage_post_clean(string $text, array $options): string {
return $text;
Expand Down Expand Up @@ -153,8 +149,6 @@ public function filter_stage_string(string $text, array $options): string {
* @param string $text The text to filter.
* @param array $options The filter options.
* @return string The filtered text for this multilang block.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function filter($text, array $options = []) {

Expand Down
2 changes: 0 additions & 2 deletions tests/actual_test_cases.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
* Returns the actual test cases for the unit tests.
*
* @return array of test cases
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
function multilang2_actual_test_cases(): array {
return [
Expand Down

0 comments on commit ea13443

Please sign in to comment.