forked from asyncapi/bindings
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from asyncapi:master #17
Open
pull
wants to merge
33
commits into
iancooper:master
Choose a base branch
from
asyncapi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dec Kolakowski <[email protected]>%0ACo-authored-by: Dec Kolakowski <[email protected]>%0ACo-authored-by: Lukasz Gornicki <[email protected]>%0ACo-authored-by: ssemyonov <[email protected]>
* Update FilterPolicy config to match AWS API Currently, filterPolicy configuration outlined in this file does not match what is outlined in the AWS documentation and API - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html. The `filterPolicy` should only contain the JSON policy, so no need for the `attributes` property; which in itself was confusing as the policy can apply to the message attributes or body. Further to this, this definition file was missing the `filterPolicyScope` which is needed to determine whether the user wishes to filter on the message attributes or the body. * Minor: remove redundant ref * Minor: match Pascal casing * Minor: amend casing * Match AWS API casing and fix example * Update SNS README --------- Co-authored-by: Dec Kolakowski <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
* docs: Add high throughput properties for fifo * Use enums * Add another example * Bump version --------- Co-authored-by: adam.gloyne <[email protected]>
Co-authored-by: Sergio Moya <[email protected]>%0ACo-authored-by: Lukasz Gornicki <[email protected]>
fix: remove git HEAD marks left in Kafka binding README.md
Co-authored-by: Sergio Moya <[email protected]>%0ACo-authored-by: Khuda Dad Nomani <[email protected]>%0ACo-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Sergio Moya <[email protected]> Co-authored-by: Sambhav Gupta <[email protected]> Co-authored-by: Jeremy Whitlock <[email protected]> Co-authored-by: Laurent Broudoux <[email protected]> Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: Cameron Rushton <[email protected]>
Co-authored-by: Goker Akce <[email protected]>
Co-authored-by: adam.gloyne <[email protected]>
* feat: Add AsyncAPI V3 compatible SNS binding definitions * feat: Remove further pubsub semantic references --------- Co-authored-by: dec.kolakowski <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )