Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify updating the exif tags dump file #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EtiennePelletier
Copy link
Contributor

@EtiennePelletier EtiennePelletier commented Sep 21, 2024

This PR addresses the issue where adding images to the repository without updating the dump file breaks the tests for exifread.

Key Changes:

  • Added a Makefile to replicate the tests for exifread, as inspired from the CI workflow. Improved flexibility for various extensions and file names.
  • In case EXIF.py isn't locally installed (e.g., for contributors who don't develop exifread), I opted to leverage uv to fetch the latest published version of exifread and run it in a virtual environment.
  • Updated the dump file by including the necessary fixes from PR #173 and PR #196 due to issues with HEIF files in the latest version of exifread.

Please see the related PR #202 that mirrors the changes to correctly find all image files in the exifread repository.

I welcome any feedback or suggestions on these changes!

🐍 🤹‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant