Skip to content

Commit

Permalink
update pylint and mypy
Browse files Browse the repository at this point in the history
  • Loading branch information
ianare committed May 2, 2023
1 parent 8bbe136 commit 317ed87
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 14 deletions.
7 changes: 0 additions & 7 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -364,13 +364,6 @@ max-line-length=120
# Maximum number of lines in a module.
max-module-lines=1000

# List of optional constructs for which whitespace checking is disabled. `dict-
# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}.
# `trailing-comma` allows a space between comma and closing bracket: (a, ).
# `empty-line` allows space-only lines.
no-space-check=trailing-comma,
dict-separator

# Allow the body of a class to be on the same line as the declaration if body
# contains single statement.
single-line-class-stmt=no
Expand Down
7 changes: 4 additions & 3 deletions exifread/jpeg.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,10 @@ def _get_base(base, data) -> int:
increment = _increment_base(data, base)
logger.debug(" Increment base by %s", increment)
base += increment
logger.debug(
" There is useful EXIF-like data here (quality, comment, copyright), " "but we have no parser for it."
)
logger.debug((
" There is useful EXIF-like data here (quality, comment, copyright), "
"but we have no parser for it."
))
else:
try:
increment = _increment_base(data, base)
Expand Down
4 changes: 2 additions & 2 deletions exifread/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ def get_gps_coords(tags: dict) -> tuple:
lat_ref_val = tags[lat_ref_tag_name].values
lat_coord_val = [c.decimal() for c in tags[lat_tag_name].values]

lng_coord = sum([c/60**i for i, c in enumerate(lng_coord_val)])
lng_coord = sum(c / 60**i for (i, c) in enumerate(lng_coord_val))
lng_coord *= (-1) ** (lng_ref_val == 'W')

lat_coord = sum([c/60**i for i, c in enumerate(lat_coord_val)])
lat_coord = sum(c / 60**i for (i, c) in enumerate(lat_coord_val))
lat_coord *= (-1) ** (lat_ref_val == 'S')

return (lat_coord, lng_coord)
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
readme_file = open("README.rst", "rt").read()

dev_requirements = [
"mypy==0.950",
"pylint==2.13.8",
"mypy==1.2.0",
"pylint==2.14.4",
]

setup(
Expand Down

0 comments on commit 317ed87

Please sign in to comment.