This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
fixes #57 - The offcanvas menu automatically closes when the input is clicked in mobile #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…input is clicked in mobile
houndci-bot
reviewed
Jul 3, 2017
| @@ -353,6 +353,8 @@ | |||
| oc = new Offcanvas $(this) | |||
|
|
|||
| $(window).on 'resize', -> | |||
| if 'text' != $(document.activeElement).attr 'type' | |||
| return | |||
There was a problem hiding this comment.
Line contains inconsistent indentation. Expected 4 got 2.
There was a problem hiding this comment.
hm.. the next two lines feature two-space indentation, at least in my IDE (VS Code):
$('.navbar-offcanvas.in').each ->
$(@).height('').removeClass 'in'
| @@ -353,6 +353,8 @@ | |||
| oc = new Offcanvas $(this) | |||
|
|
|||
| $(window).on 'resize', -> | |||
| if 'text' != $(document.activeElement).attr 'type' | |||
There was a problem hiding this comment.
Line contains inconsistent indentation. Expected 4 got 2.
There was a problem hiding this comment.
We are in CoffeeScript so we can just do
return if $(document.activeElement).attr('type') is 'text'There was a problem hiding this comment.
I'm totally fine with it
|
Not really sure how @houndci-bot didn't catch the others before, I think you can just safely ignore them 👍 |
iamphill
suggested changes
Jul 5, 2017
| @@ -353,6 +353,8 @@ | |||
| oc = new Offcanvas $(this) | |||
|
|
|||
| $(window).on 'resize', -> | |||
| if 'text' != $(document.activeElement).attr 'type' | |||
There was a problem hiding this comment.
We are in CoffeeScript so we can just do
return if $(document.activeElement).attr('type') is 'text'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57