fix: use Node20 for Javascript actions #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isnellfeikema-isp
previously approved these changes
Oct 14, 2024
|
@eviner-ISP looks like you'll have to update https://github.com/iStreamPlanet/github-actions/blob/main/.tool-versions#L1 to make the tests pass. |
Thank you @marcind |
Commenting out cache steps to test the failures...will revert this back after I test.
Test failed, un-commenting changes.
…t/github-actions into LIVE-13178-update-to-node20
eviner-ISP
requested review from
isnellfeikema-isp,
dmartin-isp,
agayle-isp and
amartin-isp
isnellfeikema-isp
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per jira https://wbdstreaming.atlassian.net/browse/LIVE-13178, updating node16 to node20.
Also needed to update typescript version to v5.6.3 (this version has support for es2023 lib)
These files looked to be the last ones that needed updating