Replaced SetEnvironmentVariable with AppendEnvironmentVariable in ignition.launch.py #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered that if anyone had set up an environment variable such as IGN_GAZEBO_RESOURCE_PATH and GN_GAZEBO_PLUGIN_PATH, the launcher overwrote them with new path.
To fix this problem, I replaced
SetEnvironmentVariable
withAppendEnvironmentVariable
in this way if the variables already existed, the launcher will append new paths otherwise it will create them.Type of change
How Has This Been Tested?
I discovered this problem when I was trying to spawn a x500 of PX4 in the world with Gazebo Garden (I forked the code and I am making the porting from Ignition to Gazebo garden) but the same problem there is also in the ignition launcher.
Possible way to test it:
Checklist