Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login-Pau #88

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Login-Pau #88

wants to merge 4 commits into from

Conversation

PaulafloresS
Copy link

#44

Copy link
Member

@3zcurdia 3zcurdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM[8]

@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not needed for the PR

@@ -129,6 +116,33 @@ struct SignUpView: View {
}
}

#Preview {
SignUpView()
extension String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‼️ extension of string it will apply to every string on the project, when you are adding functionality to a core class it needs to be be more generic/abstract and less specific

Comment on lines -81 to +62
.foregroundStyle(.maryBlue)
.foregroundColor(.maryBlue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change indicates me that you are using an older version of XCode, when that happen try to avoid to commit those changes

extension String {
func isValidPassword() -> Bool {
// Implement your password validation logic here
return self.count >= 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also its only checking for password lenght the other valiations are being skiped

}
.assign(to: \.isValidPasswordUpperCase, on: self)
.assign(to: \.isValidPassword, on: self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other bindings are being ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants