-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login-Pau #88
base: main
Are you sure you want to change the base?
Login-Pau #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM[8]
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File not needed for the PR
@@ -129,6 +116,33 @@ struct SignUpView: View { | |||
} | |||
} | |||
|
|||
#Preview { | |||
SignUpView() | |||
extension String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.foregroundStyle(.maryBlue) | ||
.foregroundColor(.maryBlue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change indicates me that you are using an older version of XCode, when that happen try to avoid to commit those changes
extension String { | ||
func isValidPassword() -> Bool { | ||
// Implement your password validation logic here | ||
return self.count >= 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also its only checking for password lenght the other valiations are being skiped
} | ||
.assign(to: \.isValidPasswordUpperCase, on: self) | ||
.assign(to: \.isValidPassword, on: self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the other bindings are being ignored
#44