-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Signup Input And Validation Rules #77
Open
eduardoquintero117
wants to merge
1
commit into
iOSLabUNAM:main
Choose a base branch
from
eduardoquintero117:feature-ModifySignupInputAndValidationRules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,26 +10,38 @@ import Combine | |
|
||
class SignUpViewModel: ObservableObject { | ||
// inputs | ||
@Published var username: String = "" | ||
@Published var email: String = "" | ||
@Published var password: String = "" | ||
@Published var passwordConfirm: String = "" | ||
|
||
// outputs | ||
@Published var isValidUsernameLength: Bool = false | ||
@Published var isValidUserEmail: Bool = false | ||
@Published var isValidPasswordLength: Bool = false | ||
@Published var isValidPasswordUpperCase: Bool = false | ||
@Published var isValidPasswordMatch: Bool = false | ||
@Published var isValid: Bool = false | ||
|
||
//Rules | ||
|
||
@Published var isValidPasswordLowerCase: Bool = false | ||
@Published var isValidPasswordSymbol: Bool = false | ||
@Published var isValidPasswordNumber: Bool = false | ||
@Published var isValidPasswordCharacter: Bool = false | ||
|
||
private var cancelableSet: Set<AnyCancellable> = [] | ||
|
||
init() { | ||
$username | ||
.receive(on: RunLoop.main) | ||
.map { username in | ||
return username.count >= 4 | ||
.map { email in | ||
let pattern = #"^\S+@\S+\.\S+$"# | ||
if let _ = email.range(of: pattern, options: .regularExpression) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
} | ||
.assign(to: \.isValidUsernameLength, on: self) | ||
.assign(to: \.isValidUserEmail, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
$password | ||
|
@@ -52,6 +64,47 @@ class SignUpViewModel: ObservableObject { | |
} | ||
.assign(to: \.isValidPasswordUpperCase, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
$password | ||
.receive(on: RunLoop.main) | ||
.map { password in | ||
let pattern = "[a-z]" | ||
if let _ = password.range(of: pattern, options: .regularExpression) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
} | ||
.assign(to: \.isValidPasswordLowerCase, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
$password | ||
.receive(on: RunLoop.main) | ||
.map { password in | ||
let pattern = "[0-9]" | ||
if let _ = password.range(of: pattern, options: .regularExpression) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
} | ||
.assign(to: \.isValidPasswordNumber, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
$password | ||
.receive(on: RunLoop.main) | ||
.map { password in | ||
let pattern = "[! # $ % & ' ( ) * + , -. / : ; < = > ? @ [ ] ^ _ ` { | }]" | ||
if let _ = password.range(of: pattern, options: .regularExpression) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
} | ||
.assign(to: \.isValidPasswordSymbol, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
|
||
|
||
Publishers.CombineLatest($password, $passwordConfirm) | ||
.receive(on: RunLoop.main) | ||
|
@@ -61,7 +114,14 @@ class SignUpViewModel: ObservableObject { | |
.assign(to: \.isValidPasswordMatch, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
Publishers.CombineLatest4($isValidUsernameLength, $isValidPasswordLength, $isValidPasswordUpperCase, $isValidPasswordMatch) | ||
Publishers.CombineLatest4($isValidUserEmail, $isValidPasswordLength, $isValidPasswordUpperCase, $isValidPasswordMatch) | ||
.map { (a, b, c, d) in | ||
return a && b && c && d | ||
} | ||
.assign(to: \.isValid, on: self) | ||
.store(in: &cancelableSet) | ||
|
||
Publishers.CombineLatest4($isValidUserEmail, $isValidPasswordLowerCase, $isValidPasswordSymbol, $isValidPasswordNumber) | ||
Comment on lines
+117
to
+124
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line 117 and line 124 are very similar |
||
.map { (a, b, c, d) in | ||
return a && b && c && d | ||
} | ||
|
@@ -80,13 +140,16 @@ struct SignUpView: View { | |
.bold() | ||
.foregroundStyle(.maryBlue) | ||
.padding(.bottom, 30) | ||
FormTextField(name: "Username", value: $vm.username) | ||
RequirementText(text: "A minimum of 4 characters", isValid: vm.isValidUsernameLength) | ||
FormTextField(name: "E–mail", value: $vm.email) | ||
RequirementText(text: "Email is valid", isValid: vm.isValidUserEmail) | ||
.padding() | ||
FormTextField(name: "Password", value: $vm.password, isSecure: true) | ||
VStack { | ||
RequirementText(text: "A minimum of 8 characters", isValid: vm.isValidPasswordLength) | ||
RequirementText(text: "One uppercase letter", isValid: vm.isValidPasswordUpperCase) | ||
RequirementText(text: "One lowercase letter", isValid: vm.isValidPasswordLowerCase) | ||
RequirementText(text: "One symbol", isValid: vm.isValidPasswordSymbol) | ||
RequirementText(text: "One number", isValid: vm.isValidPasswordNumber) | ||
} | ||
.padding() | ||
FormTextField(name: "Confirm Password", value: $vm.passwordConfirm, isSecure: true) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid spaces in regex and use non word regex