-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signup exercise succeed #68
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM[8]
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File not needed on PR
|
||
@Published var isValidPasswordLowerCase: Bool = false | ||
|
||
@Published var isValidPasswordHasNumber: Bool = false | ||
|
||
@Published var isValidPasswordHasSpecialCharacter: Bool = false | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many line jumps
let pattern = "[A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,64}" | ||
if let _ = username.range(of: pattern, options: .regularExpression) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
} | ||
.assign(to: \.isValidUsernameLength, on: self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the username validating email?
.receive(on: RunLoop.main) | ||
.map { | ||
password in | ||
let pattern = "[!@#$%^&*]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let pattern = "[!@#$%^&*]" | |
let pattern = "[\\W]" |
fixing #44