Look for open closed state first #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
reviewed
Nov 19, 2021
| state = self.executor.select_state( | ||
| CORE_OPEN_CLOSED_STATE, | ||
| CORE_SLATS_OPEN_CLOSED_STATE, | ||
| CORE_OPEN_CLOSED_PARTIAL_STATE, | ||
| CORE_OPEN_CLOSED_PEDESTRIAN_STATE, | ||
| CORE_OPEN_CLOSED_UNKNOWN_STATE, | ||
| MYFOX_SHUTTER_STATUS_STATE, |
There was a problem hiding this comment.
Why did you remove this one? If I recall correctly, we use this for the Camera Shutter.
There was a problem hiding this comment.
Ah yes indeed, sorry. I found the issue where you add it. Feel weird to me to have it as a cover and not has a switch.
tetienne
force-pushed
the
fix/gate-position
branch
from
50b6651
to
57d7a8e
Compare
|
@iMicknl Can you please review and merge this PR ? |
iMicknl
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #487