Merge pull request #605 from iKostanOrg/master

[ikostan]

• Merge from master
• Conversion between Kilobyte and KibiByte

Summary by Sourcery

New Features:

• Implement conversion between kilobytes (kB) and kibibytes (KiB).

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request implements the "Conversion between Kilobyte and KibiByte" kata and merges changes from the master branch. The implementation involves creating a conversion function that handles various memory size units (kB, MB, GB, TB, KiB, MiB, GiB, TiB) and performs the conversion with appropriate rounding. A helper function extracts the unit and conversion ratio from the input string. The solution also includes unit tests to verify the correctness of the implementation.

Sequence diagram for memory size conversion process

sequenceDiagram
    participant Client
    participant Converter
    participant UnitExtractor

    Client->>Converter: memorysize_conversion('10 KiB')
    Converter->>UnitExtractor: unit_extractor('10 KiB')
    UnitExtractor-->>Converter: return ('kB', 1.024)
    Converter->>Converter: Convert value using ratio
    Converter->>Converter: Format result
    Converter-->>Client: return '10.24 kB'

Loading

Class diagram for memory size conversion implementation

classDiagram
    class MemorySizeConverter {
        +UNITS: dict
        +memorysize_conversion(memory_size: str) -> str
        +unit_extractor(memory_size: str) -> tuple
    }
    note for MemorySizeConverter "UNITS dictionary maps between
KiB/kB units and their conversion ratios"

Loading

File-Level Changes

Change	Details	Files
Implementation of the "Conversion between Kilobyte and Kibibyte" kata.	Added memorysize_conversion function to convert between kB and KiB units. Added unit_extractor helper function to extract unit and conversion ratio. Created unit tests for the conversion function. Added a README file explaining the kata and solution. Added documentation files for the solution. Updated the list of completed kata in the main README file to include the new kata and link to the solution on GitHub	kyu_6/conversion_between_kilobyte_and_kibibyte/solution.py kyu_6/conversion_between_kilobyte_and_kibibyte/test_memory_size_conversion.py kyu_6/conversion_between_kilobyte_and_kibibyte/README.md kyu_6/conversion_between_kilobyte_and_kibibyte/__init__.py docs/kyu_6/kyu_6.conversion_between_kilobyte_and_kibibyte.module.rst docs/kyu_6/kyu_6.conversion_between_kilobyte_and_kibibyte.readme.rst docs/kyu_6/kyu_6.conversion_between_kilobyte_and_kibibyte.rst
Merged changes from the master branch.	Updated the list of completed kata in the main README file to reflect the merge from master. Added a new entry for the "Conversion between Kilobyte and KibiByte" kata to the list of completed kata in the main README file with a link to the solution on GitHub	kyu_6/README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We have skipped reviewing this pull request. Here's why:

• We don't review packaging changes - Let us know if you'd like us to change this.
• All of the files are larger than we can process. We're working on it!

[codeclimate]

Code Climate has analyzed commit ffb0bdd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.5% (0.0% change).

View more on Code Climate.

[ikostan]

@sourcery-ai review

[sourcery-ai]

Hey @ikostan - I've reviewed your changes - here's some feedback:

Overall Comments:

• There are duplicate entry numbers in the table (two Bump sphinxcontrib-htmlhelp from 1.0.2 to 1.0.3 #8 entries) - please fix the numbering sequence

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}