-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #582
Documentation #582
Conversation
Check notice on line 1 in kyu_8/find_the_first_non_consecutive_number/__init__.py @codacy-production codacy-production / Codacy Static Code Analysis kyu_8/find_the_first_non_consecutive_number/__init__.py#L1 Final newline missing
Merge from master
Reviewer's Guide by SourceryThis pull request adds documentation for katas in kyu levels 2 through 8. It also adds documentation specifically for the "factorial decomposition" kata in kyu 5. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ikostan - I've reviewed your changes - here's some feedback:
Overall Comments:
- PR title should be more descriptive - specify what documentation is being added (e.g. 'Add factorial decomposition documentation to kyu_5')
- Remove empty diffs for unmodified kyu_* directories to keep the PR focused on actual changes
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Code Climate has analyzed commit 9692f8a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (0.0% change). View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 90.85% 90.47% -0.39%
==========================================
Files 174 174
Lines 2669 2561 -108
==========================================
- Hits 2425 2317 -108
Misses 244 244 ☔ View full report in Codecov by Sentry. |
checking consistency... /home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_2/kyu_2.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_3/kyu_3.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_4/kyu_4.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_5/kyu_5.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_6/kyu_6.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_7/kyu_7.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/docs/kyu_8/kyu_8.readme.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/codewars/checkouts/582/kyu_8/alternating_case/README.md:9: WARNING: Pygments lexer name 'test' is not known
Merge pull request #582 from iKostanOrg/Documentation
Summary by Sourcery
Add documentation for the "Factorial Decomposition" kata.
New Features:
Documentation: