Merge from master #577
Merged
Merge from master #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #572 from iKostanOrg/master
./kyu_8/closest_elevator/closest_elevator.py:8:1: E302 expected 2 blank lines, found 1 def elevator(left: int, right: int, call: int) -> str:
./kyu_8/enumerable_magic_25/test_take.py:65:27: E127 continuation line over-indented for visual indent
n=n,
^
./kyu_8/enumerable_magic_25/test_take.py:66:27: E127 continuation line over-indented for visual indent
expected=expected,
^
./kyu_8/enumerable_magic_25/test_take.py:67:27: E127 continuation line over-indented for visual indent
result=actual_result)
Error: kyu_8/closest_elevator/README.md:21 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md040.md
Merge from master
90.41% (-0.39%) compared to 2f84a83
suggestion (code-quality): Convert for loop into list comprehension (list-comprehension)
Trailing newlines
kyu_8/logical_calculator/
test_logical_calculator_error.py
62
self.assertEqual(str(calc_err.value), err)
Unnecessary parens after 'with' keyword
kyu_8/logical_calculator/
test_logical_calculator_error.py
51
"</p>")
52
# pylint: enable=R0801
53
with (allure.step("Pass an array with invalid operator.")):
54
arr: list = []
55
op: str = 'RO' # invalid operator
Unused print_log imported from utils.log_func kyu_8/logical_calculator/ test_logical_calculator_error.py 13 from utils.log_func import print_log
Merge pull request #575 from iKostanOrg/master
./kyu_7/complete_the_pattern_5_even_ladder/solution.py:8:1: E302 expected 2 blank lines, found 1 def pattern(n: int) -> str: ^ 1 E302 expected 2 blank lines, found 1
kyu_8/logical_calculator/test_logical_calculator_error.py:35 in public method `test_logical_calc_value_error`:
D205: 1 blank line required between summary line and description (found 0)
Multi-line docstrings consist of a summary line just like a one-line
docstring, followed by a blank line, followed by a more elaborate
description. The summary line may be used by automatic indexing tools;
it is important that it fits on one line and is separated from the
rest of the docstring by a blank line.
Reviewer's Guide by SourceryThis pull request implements a pydocstyle check in the CI pipeline and adds a new kata 'Complete The Pattern #5 - Even Ladder'. It also includes minor updates to existing files such as adding Allure annotations, updating print statements, and fixing YAML formatting. Class diagram for new kata implementationclassDiagram
class pattern {
+pattern(n: int) -> str
}
note for pattern "Complete The Pattern #5 - Even Ladder
Generates pattern up to n/2 lines
Returns empty string if n <= 1"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kyu8 #577 +/- ##
==========================================
+ Coverage 90.39% 90.48% +0.09%
==========================================
Files 172 174 +2
Lines 2550 2565 +15
==========================================
+ Hits 2305 2321 +16
+ Misses 245 244 -1 ☔ View full report in Codecov by Sentry. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ikostan - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ikostan
added a commit
that referenced
this pull request
Dec 25, 2024
Merge pull request #577 from iKostanOrg/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add "Complete The Pattern #5 - Even Ladder" kata, tests and workflows.
New Features:
Tests: