Merge pull request #561 from iKostanOrg/master #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #560 from iKostanOrg/kyu6
Reviewer's Guide by SourceryThis pull request refactors test cases in Class diagram for DefaultList implementationclassDiagram
class DefaultList {
-list __lst
-str default_value
+__init__(lst: list, default_value: str)
+__getitem__(i: int)
+extend(items: list)
+append(item)
+pop(item)
+remove(item)
+insert(index: int, item)
}
note for DefaultList "Implements a list with default value for out of range indices"
Class diagram for Potion implementationclassDiagram
class Potion {
-Tuple _color
-int _volume
+__init__(color: Tuple, volume: int)
+mix(other: Potion) Potion
+volume() int
+volume(value: int)
+color() tuple
+color(value: Tuple)
}
note for Potion "Represents a potion with color and volume properties"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ikostan - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 172 172
Lines 2537 2537
=======================================
Hits 2292 2292
Misses 245 245 ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit 8f7dce0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 94.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.3% (0.0% change). View more on Code Climate. |
kyu_6/format_string_of_names/test_namelist.py:1 at module level:
D301: Use r""" if any backslashes in a docstring
Use r"""raw triple double quotes""" if you use any backslashes
(\) in your docstrings.
Exceptions are backslashes for line-continuation and unicode escape
sequences \N... and \u... These are considered intended unescaped
content in docstrings.
kyu_6/format_string_of_names/solution.py:1 at module level:
D301: Use r""" if any backslashes in a docstring
Use r"""raw triple double quotes""" if you use any backslashes
(\) in your docstrings.
Exceptions are backslashes for line-continuation and unicode escape
sequences \N... and \u... These are considered intended unescaped
content in docstrings.
kyu_6/who_likes_it/test_likes_function.py:33 in public class `LikesTestCase`:
D400: First line should end with a period (not 'n')
The [first line of a] docstring is a phrase ending in a period.
kyu_6/format_string_of_names/test_namelist.py:1 at module level:
D301: Use r""" if any backslashes in a docstring
Use r"""raw triple double quotes""" if you use any backslashes
(\) in your docstrings.
Exceptions are backslashes for line-continuation and unicode escape
sequences \N... and \u... These are considered intended unescaped
content in docstrings.
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @ikostan - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
No name 'to_table' in module 'kyu_6.array_to_html_table' kyu_6/array_to_html_table/ test_list_to_html_table.py 10 import allure 11 from utils.log_func import print_log 12 from kyu_6.array_to_html_table.to_table import to_table 13 Time to fix: 5 minutes no-name-in-module (E0611) Why is this an issue? No name %r in module %r Used when a name cannot be found in a module.
suggestion (testing): Consider adding a test case with duplicate categories in the stock list. This would ensure the function correctly handles scenarios where multiple books belong to the same category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pull request #560 from iKostanOrg/kyu6
Summary by Sourcery
Tests: