Merge from master #550
Merged
Merge from master #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 17 to 18. - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@v17...v18) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.6.0 to 5.0.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.6.0...v5.0.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…-github/workflows/DavidAnson/markdownlint-cli2-action-18 Bump DavidAnson/markdownlint-cli2-action from 17 to 18 in /.github/workflows
…-github/workflows/codecov/codecov-action-5.0.2 Bump codecov/codecov-action from 4.6.0 to 5.0.2 in /.github/workflows
kyu_3/battleship_field_validator/test_battleship_validator.py:1 at module level:
D205: 1 blank line required between summary line and description (found 0)
Multi-line docstrings consist of a summary line just like a one-line
docstring, followed by a blank line, followed by a more elaborate
description. The summary line may be used by automatic indexing tools;
it is important that it fits on one line and is separated from the
rest of the docstring by a blank line.
kyu_3/line_safari_is_that_a_line/test_line_positive.py:34 in public method `test_line_positive`:
D202: No blank lines allowed after function docstring (found 1)
There's no blank line either before or after the docstring unless directly
followed by an inner function or class.
./kyu_3/line_safari_is_that_a_line/test_line_negative.py:42:1: W293 blank line contains whitespace
"""
Testing Line Safari functionality.
Negative test cases.
:return:
"""
^
kyu_3/line_safari_is_that_a_line/line_safari.py:1 at module level:
D400: First line should end with a period (not '?')
The [first line of a] docstring is a phrase ending in a period.
kyu_3/line_safari_is_that_a_line/test_walker.py:30 in public class `WalkerClassTestCase`:
D200: One-line docstring should fit on one line with quotes (found 3)
The closing quotes are on the same line as the opening quotes.
This looks better for one-liners.
kyu_3/line_safari_is_that_a_line/test_walker.py:30 in public class `WalkerClassTestCase`:
D204: 1 blank line required after class docstring (found 0)
Insert a blank line before and after all docstrings (one-line or
multi-line) that document a class -- generally speaking, the class's
methods are separated from each other by a single blank line, and the
docstring needs to be offset from the first method by a blank line;
for symmetry, put a blank line between the class header and the
docstring.
./kyu_3/line_safari_is_that_a_line/test_walker.py:31:1: W293 blank line contains whitespace
./kyu_3/line_safari_is_that_a_line/walker_class.py:222:5: E303 too many blank lines (2)
def __test_down(self) -> bool:
^
./kyu_3/line_safari_is_that_a_line/walker_class.py:228:5: E303 too many blank lines (2)
def __test_left(self) -> bool:
^
./kyu_3/line_safari_is_that_a_line/walker_class.py:234:5: E303 too many blank lines (2)
def __test_right(self) -> bool:
^
Merge pull request #548 from iKostanOrg/master + pydocstyle implementation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request #550 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 2211.
ikostan
added a commit
that referenced
this pull request
Dec 8, 2024
Pydocstyle + Merge pull request #550 from iKostanOrg/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.