Merge #548
Merged
Merge #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu_2/evaluate_mathematical_expression/evaluate.py:15 in public function `calculate`:
D205: 1 blank line required between summary line and description (found 0)
Multi-line docstrings consist of a summary line just like a one-line
docstring, followed by a blank line, followed by a more elaborate
description. The summary line may be used by automatic indexing tools;
it is important that it fits on one line and is separated from the
rest of the docstring by a blank line.
kyu_2/evaluate_mathematical_expression/evaluate.py:15 in public function `calculate`:
D400: First line should end with a period (not 'n')
The [first line of a] docstring is a phrase ending in a period.
./kyu_2/evaluate_mathematical_expression/evaluate.py:175:1: W293 blank line contains whitespace
"""
Normalizing string input by checking conditions.
:param strings: list
:param string: str
:param temp: str
:return: tuple(str, str)
"""
kyu_2/evaluate_mathematical_expression/evaluate.py:79 in public function `process_brackets`:
D205: 1 blank line required between summary line and description (found 0)
Multi-line docstrings consist of a summary line just like a one-line
docstring, followed by a blank line, followed by a more elaborate
description. The summary line may be used by automatic indexing tools;
it is important that it fits on one line and is separated from the
rest of the docstring by a blank line.
kyu_2/evaluate_mathematical_expression/evaluate.py:79 in public function `process_brackets`:
D400: First line should end with a period (not 't')
The [first line of a] docstring is a phrase ending in a period.
kyu_2/evaluate_mathematical_expression/evaluate.py:173 in public function `check_conditions`:
D401: First line should be in imperative mood (perhaps 'Normalize', not 'Normalizing')
[Docstring] prescribes the function or method's effect as a command:
("Do this", "Return that"), not as a description; e.g. don't write
"Returns the pathname ...".
pydocstyle implementation - Merge pull request #546 from iKostanOrg/master
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request #548 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 2196.
ikostan
added
documentation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ikostan
added a commit
that referenced
this pull request
Dec 5, 2024
Merge pull request #548 from iKostanOrg/master + pydocstyle implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from master