Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valid Parentheses - Merge pull request #543 from iKostanOrg/master #544
Valid Parentheses - Merge pull request #543 from iKostanOrg/master #544
Changes from 6 commits
8723bc1
8696585
983584e
80d5b1c
313929a
c1cfe59
6741ceb
18c197a
69f07a7
ab6ed0c
4f9d623
2c6a0e6
d917260
14b2efc
d7a5a1e
d878cbc
c9dba87
be39032
6f0f5ac
cde890e
d87e55d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (complexity): Consider using a counter-based approach instead of string manipulation to validate parentheses
The current implementation unnecessarily rebuilds strings and uses nested loops, leading to O(n²) complexity. This can be simplified to O(n) using a counter approach that better expresses the intent:
This solution:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
valid_parentheses
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.Check notice on line 46 in kyu_7/valid_parentheses/solution.py
codefactor.io / CodeFactor
kyu_7/valid_parentheses/solution.py#L46
Check notice on line 52 in kyu_7/valid_parentheses/solution.py
Codacy Production / Codacy Static Code Analysis
kyu_7/valid_parentheses/solution.py#L52