Merge from master to kyu7 #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
Merge from master
kyu_3/calculator/calculator.py:31: error: Argument 1 to "float" has incompatible type "Any | None"; expected "str | Buffer | SupportsFloat | SupportsIndex" [arg-type] kyu_3/calculator/calculator.py:87: error: Attribute "__string" already defined on line 19 [no-redef] kyu_3/calculator/calculator.py:88: error: Attribute "__string" already defined on line 19 [no-redef] kyu_3/calculator/calculator.py:90: error: Attribute "__string" already defined on line 19 [no-redef]
kyu_3/calculator/calculator.py:87: error: Attribute "__string" already defined on line 19 [no-redef] kyu_3/calculator/calculator.py:89: error: Attribute "__string" already defined on line 19 [no-redef]
kyu_3/battleship_field_validator/validator.py:60: error: Name "ship" already defined on line 43 [no-redef] kyu_3/battleship_field_validator/validator.py:100: error: Name "ship" already defined on line 83 [no-redef]
Missing whitespace after ',' New
self.__process_math_expression(string,['*', '/']))
Severity: MinorFound in kyu_3/calculator/calculator.py by pep8
Missing whitespace after ',' New
self.__process_math_expression(self.__string,['+', '-']))
Severity: MinorFound in kyu_3/calculator/calculator.py by pep8
Avoid deeply nested control flow statements. New
if all(is_valid_cell(ships=ships,
field=field,
cell=cell,
direction='horizontal') for cell in ship):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Avoid deeply nested control flow statements. New
if all(is_valid_cell(ships=ships,
field=field,
cell=cell,
direction='vertical') for cell in ship):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Avoid deeply nested control flow statements. New
if all(is_valid_cell_h):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Avoid deeply nested control flow statements. New
if all(is_valid_cell(ships=ships,
field=field,
cell=cell,
direction='vertical') for cell in ship):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Avoid deeply nested control flow statements. New
if all_cells_valid(ships=ships,
field=field,
direction='horizontal',
ship=ship):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Avoid deeply nested control flow statements. New
if all_cells_valid(ships=ships,
field=field,
direction='vertical',
ship=ship):
ships[len(ship)].append(ship)
Severity: MajorFound in kyu_3/battleship_field_validator/validator.py - About 45 mins to fix
Line too long (87 > 79 characters) New
direction=kwargs['direction']) for cell in kwargs['ship'])
Severity: MinorFound in kyu_3/battleship_field_validator/validator.py by pep8
Line too long (83 > 79 characters) New
direction='horizontal',
Severity: MinorFound in kyu_3/battleship_field_validator/validator.py by pep8
Line too long (81 > 79 characters) New
direction='vertical',
Severity: MinorFound in kyu_3/battleship_field_validator/validator.py by pep8
Merge from master
Merge from master
Merge pull request #485 from iKostanOrg/master
kyu_6/first_character_that_repeats/first_character_that_repeats.py:8: error: Syntax error in type annotation [syntax] kyu_6/first_character_that_repeats/first_character_that_repeats.py:8: note: Suggestion: Use Tuple[T1, ..., Tn] instead of (T1, ..., Tn)
Merge pull request #501 from iKostanOrg/master
ikostan
added a commit
that referenced
this pull request
Oct 24, 2024
Merge pull request #503 from iKostanOrg/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.