cleaning so todos

iExecBlockchainComputing · May 29, 2024 · c5e18f9 · c5e18f9
1 parent f37033e
commit c5e18f9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/contracts/VoucherHub.sol b/contracts/VoucherHub.sol
@@ -237,7 +237,7 @@ contract VoucherHub is
      */
     function getVoucherType(
         uint256 id
-    ) public view whenVoucherTypeExists(id) returns (VoucherType memory) {
+    ) external view whenVoucherTypeExists(id) returns (VoucherType memory) {
         VoucherHubStorage storage $ = _getVoucherHubStorage();
         return $.voucherTypes[id];
     }

diff --git a/contracts/beacon/Voucher.sol b/contracts/beacon/Voucher.sol
@@ -104,9 +104,7 @@ contract Voucher is OwnableUpgradeable, IVoucher {
         IexecLibOrders_v5.DatasetOrder calldata datasetOrder,
         IexecLibOrders_v5.WorkerpoolOrder calldata workerpoolOrder,
         IexecLibOrders_v5.RequestOrder calldata requestOrder
-    ) external returns (bytes32 dealId) {
-        // TODO add onlyAuthorized
-        // TODO check expiration
+    ) external onlyAuthorized onlyNotExpired returns (bytes32 dealId) {
         VoucherStorage storage $ = _getVoucherStorage();
         IVoucherHub voucherHub = IVoucherHub($._voucherHub);
         address iexecPoco = voucherHub.getIexecPoco();