Feature/modular app templates #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…/modular-app-templates
Merged
| @@ -11,6 +11,7 @@ export const TEST_INPUT_DIR = 'input'; | |||
| export const TEST_OUTPUT_DIR = 'output'; | |||
| export const RUN_OUTPUT_DIR = 'output'; // Same as TEST_OUTPUT_DIR | |||
| export const CACHE_DIR = 'cache'; | |||
| export const PROTECTED_DATA_MOCK_DIR = 'mock/protectedData'; | |||
There was a problem hiding this comment.
ProtectedData mocks are stored in mock/protectedData, we may want to store them in cache/mock/protectedData for lesser visibility?
This is a preliminary refactor to enable supporting multiple protectedData mocks; a default protectedData mock is provided.
Le-Caignec
reviewed
Dec 16, 2024
| type: 'confirm', | ||
| name: 'useRequesterSecret', | ||
| message: | ||
| 'Would you like to use requester secrets inside your iApp? (requester secrets are secrets provisioned by the user)', |
There was a problem hiding this comment.
Suggested change
| 'Would you like to use requester secrets inside your iApp? (requester secrets are secrets provisioned by the user)', | |
| 'Would you like to use requester secrets inside your iApp? (requester secrets are secrets that will be provided by any users that will run your iapp)', |
| type: 'confirm', | ||
| name: 'useAppSecret', | ||
| message: | ||
| 'Would you like to use an app secret inside your iApp? (app secret is a secret provisioned by the app owner)', |
There was a problem hiding this comment.
Suggested change
| 'Would you like to use an app secret inside your iApp? (app secret is a secret provisioned by the app owner)', | |
| 'Would you like to use an app secret inside your iApp? (app secret is a secret provisioned by the app owner linked to your iapp that will never changed)', |
| message: 'What kind of project do you want to init?', | ||
| choices: [ | ||
| { | ||
| title: 'hello-world', |
There was a problem hiding this comment.
what do you think about using PascalCase here ?
Suggested change
| title: 'hello-world', | |
| title: 'HelloWorld', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modular template
choose init type (
hello-worldoradvanced)hello-world- get started with a simple "hello-world" app (only useargs)advanced- pick the features you wantUser choices produce a template with selected features (technically we strip unwanted features from a "full-featured" template)
misc
mock/protectedDataand copied ininputfolder when neededinputis now cleaned before eachiapp testiapp.config.jsonhas been added to ignore files as it may contain some secrets