Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependency Harfbuzz to GTK3 #21

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7ab44f4
Support for multiple sockets
XaviDCR92 Apr 20, 2020
aecaf18
Added dynstr, fixed NULL pointer access
XaviDCR92 Apr 23, 2020
486666e
Introduced dynstr, other breaking changes
XaviDCR92 May 2, 2020
90fb1eb
Added missing dependency Harfbuzz to GTK3
XaviDCR92 May 20, 2020
da7b01b
Merge branch 'master' into multisockets
XaviDCR92 May 20, 2020
004a305
client_socket was being accidentally reset to -1
XaviDCR92 May 21, 2020
aea565d
Added GDB server on CpuCfg UI dialog, rearranged layout
XaviDCR92 May 21, 2020
470da05
Started implementing GDB server
XaviDCR92 May 22, 2020
850010a
Replaced in-house gdb stub by MIT-licensed implementation
XaviDCR92 May 23, 2020
85141ac
OpenGL_GL_PREFERENCE set to LEGACY
XaviDCR92 Jun 2, 2020
cb2d7f8
Implemented port-specific wrappers and logic for gdb stub
XaviDCR92 May 28, 2020
ece9012
Added "-gdb" command line argument to start gdb stub
XaviDCR92 Jun 2, 2020
66d4b1a
OpenGL_GL_PREFERENCE set to LEGACY
XaviDCR92 Jun 2, 2020
0521d57
Merge branch 'multisockets'
XaviDCR92 Jun 4, 2020
90af551
Updated gdbstub
XaviDCR92 Jun 5, 2020
4458c53
Make execI() wait until queue is initialized
XaviDCR92 Jun 5, 2020
aa89de2
gdb halt command was not being sent to CPU interpreter
XaviDCR92 Jun 7, 2020
5676534
Attempt to make gdb server to exit gracefully
XaviDCR92 Jun 7, 2020
76b11a3
Do not continue program on add/remove breakpoint
XaviDCR92 Oct 26, 2020
4006528
Set sockets to invalid value on init
XaviDCR92 Oct 26, 2020
7cc5124
Make socket blocking on dbg_sys_getc
XaviDCR92 Oct 26, 2020
7e152c0
Force Config.Debug=0 on GDB server enabled
XaviDCR92 Oct 26, 2020
dfc42ba
Add -gdb flag into documentation
XaviDCR92 Oct 26, 2020
842a347
Call perror on socket.c
XaviDCR92 Nov 3, 2020
5d8182c
Use select(2) when accessing several file descriptors at once
XaviDCR92 Nov 3, 2020
2dde7bc
Notify gdb stub whenever a break instruction is executed
XaviDCR92 Nov 3, 2020
a1b716f
Fix typo in string
XaviDCR92 Nov 3, 2020
364102c
Provisionally redirect RawReadSocket to ReadSocket
XaviDCR92 Nov 3, 2020
28b866b
Consider sockets less than zero as invalid
XaviDCR92 Dec 30, 2020
bf989ae
Fix typo on fprintf call
XaviDCR92 Dec 30, 2020
ca3b98c
Reset Config.GdbServer if GDB server init fails
XaviDCR92 Dec 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[submodule "dynstr/dynstr"]
path = dynstr/dynstr
url = https://github.com/XaviDCR92/dynstr
[submodule "gdbstub/gdbstub"]
path = gdbstub/gdbstub
url = https://github.com/XaviDCR92/gdbstub
7 changes: 4 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ add_definitions(-DPACKAGE_NAME="PCSXr")
add_definitions(-DPACKAGE_STRING="PCSXr ${PCSXR_VERSION_MAJOR}.${PCSXR_VERSION_MINOR}.${PCSXR_VERSION_PATCH}")
set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -s")
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -s")
#uncomment for gdb server debugging
#add_definitions(-DDEBUG=1)

include(CheckCCompilerFlag)
include(GNUInstallDirs)
Expand Down Expand Up @@ -51,6 +53,5 @@ add_subdirectory(libpcsxcore)
add_subdirectory(gui)
add_subdirectory(plugins)
add_subdirectory(doc)



add_subdirectory(dynstr)
add_subdirectory(gdbstub)
3 changes: 2 additions & 1 deletion cmake/FindGTK3.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ set(GTK3_DEPS
GDK3
Pango
Cairo
GDKPixbuf)
GDKPixbuf
Harfbuzz)

if(PKG_CONFIG_FOUND)
pkg_search_module(GTK3_PKG QUIET gtk+-3.0)
Expand Down
58 changes: 58 additions & 0 deletions cmake/FindHarfbuzz.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
find_package(PkgConfig)

set(Harfbuzz_DEPS)

if(PKG_CONFIG_FOUND)
pkg_search_module(Harfbuzz_PKG harfbuzz)
endif()

find_library(Harfbuzz_LIBRARY harfbuzz HINTS ${Harfbuzz_PKG_LIBRARY_DIRS})
set(Harfbuzz harfbuzz)

if(Harfbuzz_LIBRARY)
add_library(${Harfbuzz} SHARED IMPORTED)
set_property(TARGET ${Harfbuzz} PROPERTY IMPORTED_LOCATION "${Harfbuzz_LIBRARY}")
set_property(TARGET ${Harfbuzz} PROPERTY INTERFACE_COMPILE_OPTIONS "${Harfbuzz_PKG_CFLAGS_OTHER}")

set(Harfbuzz_INCLUDE_DIRS)

find_path(Harfbuzz_INCLUDE_DIR "hb.h"
HINTS ${Harfbuzz_PKG_INCLUDE_DIRS})

if(Harfbuzz_INCLUDE_DIR)
file(STRINGS "${Harfbuzz_INCLUDE_DIR}/hb-version.h" HB_VERSION_MAJOR REGEX "^#define HB_VERSION_MAJOR +\\(?([0-9]+)\\)?$")
string(REGEX REPLACE "^#define HB_VERSION_MAJOR \\(?([0-9]+)\\)?$" "\\1" HB_VERSION_MAJOR "${HB_VERSION_MAJOR}")
file(STRINGS "${Harfbuzz_INCLUDE_DIR}/hb-version.h" HB_VERSION_MINOR REGEX "^#define HB_VERSION_MINOR +\\(?([0-9]+)\\)?$")
string(REGEX REPLACE "^#define HB_VERSION_MINOR \\(?([0-9]+)\\)?$" "\\1" HB_VERSION_MINOR "${HB_VERSION_MINOR}")
file(STRINGS "${Harfbuzz_INCLUDE_DIR}/hb-version.h" HB_VERSION_MICRO REGEX "^#define HB_VERSION_MICRO +\\(?([0-9]+)\\)?$")
string(REGEX REPLACE "^#define HB_VERSION_MICRO \\(?([0-9]+)\\)?$" "\\1" HB_VERSION_MICRO "${HB_VERSION_MICRO}")
set(Harfbuzz_VERSION "${HB_VERSION_MAJOR}.${HB_VERSION_MINOR}.${HB_VERSION_MICRO}")
unset(HB_VERSION_MAJOR)
unset(HB_VERSION_MINOR)
unset(HB_VERSION_MICRO)

list(APPEND Harfbuzz_INCLUDE_DIRS ${Harfbuzz_INCLUDE_DIR})
set_property(TARGET ${Harfbuzz} PROPERTY INTERFACE_INCLUDE_DIRECTORIES "${Harfbuzz_INCLUDE_DIR}")
endif()
endif()

set(Harfbuzz_DEPS_FOUND_VARS)
foreach(harfbuzz_dep ${Harfbuzz_DEPS})
find_package(${harfbuzz_dep})

list(APPEND Harfbuzz_DEPS_FOUND_VARS "${harfbuzz_dep}_FOUND")
list(APPEND Harfbuzz_INCLUDE_DIRS ${${harfbuzz_dep}_INCLUDE_DIRS})

set_property (TARGET ${Harfbuzz} APPEND PROPERTY INTERFACE_LINK_LIBRARIES "${${harfbuzz_dep}}")
endforeach(harfbuzz_dep)

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Harfbuzz
REQUIRED_VARS
Harfbuzz_LIBRARY
Harfbuzz_INCLUDE_DIRS
${Harfbuzz_DEPS_FOUND_VARS}
VERSION_VAR
Harfbuzz_VERSION)

unset(Harfbuzz_DEPS_FOUND_VARS)
5 changes: 5 additions & 0 deletions dynstr/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
message(STATUS "* Configuring dynstr")

set(SRCS dynstr/dynstr.c)
include_directories(dynstr/include)
add_library(dynstr STATIC ${SRCS})
1 change: 1 addition & 0 deletions dynstr/dynstr
Submodule dynstr added at 357d4f
5 changes: 5 additions & 0 deletions gdbstub/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
message(STATUS "* Configuring gdbstub")

set(SRCS gdbstub/gdbstub.c gdbstub_sys.c)
include_directories(gdbstub .)
add_library(gdbstub STATIC ${SRCS})
1 change: 1 addition & 0 deletions gdbstub/gdbstub
Submodule gdbstub added at 1266e6
Loading