Fix: Vue 2/3 lifecycle type errors and script tag cleanup

[ubercj]

Purpose of PR

This PR is to address a couple of bug issues:

#73

• googleTranslateSelectObserve and htmlAttrLangObserve are now checked for null during onBeforeUnmount. It looks like this is actually already done in the React package, so the Vue packages should be the same now.

#78

• The script tag from createScript is now removed in onBeforeUnmount. Then, when the page changes, a new script tag is inserted during onMounted and the script is run to reinject the .goog-te-combo element in the DOM. This ensures that the hidden select tag (.goog-te-combo) is present in between page loads in a SPA, for example.

PR Checklist

• I have read the relevant readme.md file(s)
• Tests are added/updated/not required
• Tests are passing
• Storybook stories are added/updated/not required
• Usage notes are added/updated/not required
• Doesn't contain any sensitive information

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0b96387

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
google-translate-select-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2023 3:23pm

[TooColline]

Nice work @ubercj. Let's get this merged in @i7eo if it looks good to you

[ubercj]

@i7eo have you had a chance to look at this?

Let me know if any edits are needed to get this merged in. It would be great to get this fixed so I can start using this package on my site

[i7eo]

@i7eo have you had a chance to look at this?

Let me know if any edits are needed to get this merged in. It would be great to get this fixed so I can start using this package on my site

Sorry guys, I've been very busy lately. I checked your pr and there is no problem, it has been merged

[i7eo]

You can check version 0.1.2, Thanks @ubercj 👏

[ubercj]

Sweet, thanks @i7eo! I updated to v0.1.2 and it's working great for me 👍

[TooColline]

Has the change been effected for the Vue 2 counterpart? i.e. @google-translate-select/vue2 forgot to review that part because I'm still experiencing it on the Vue 2 package

cc: @ubercj @i7eo

[i7eo]

Has the change been effected for the Vue 2 counterpart? i.e. @google-translate-select/vue2 forgot to review that part because I'm still experiencing it on the Vue 2 package

cc: @ubercj @i7eo

Yeah, you can bump your @google-translate-select/vue2 version from 0.1.1 to 0.1.2.

[i7eo]

@all-contributors please add @ubercj for code

[allcontributors]

@i7eo

I've put up a pull request to add @ubercj! 🎉