Fixes issue with double dash "--" inside quotes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Horvath <[email protected]>
mrhorvath
force-pushed
the
bug/oracle_ant_comment_inserts
branch
from
f3ca594 to
40b8300
Compare
|
@mikemendis @reetametta This request looks good to me. Let's discuss if we all feel it is ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/12469496/ant-sql-insert-statement-fails-on-strings-workaround
Several inserts for ACT ICD9CM ontology include "--" inside of the quote, which ant is handling poorly.
"E831.2 Accident to watercraft causing other injury to occupant of other watercraft -- crew"
The -- is interpreted as the beginning of a comment despite being in quotes and created several errors on insert during the load.
This appears to only apply to ant sql tasks with oracle and may be an issue with the jdbc driver as discussed in the stackoverflow link above.
Setting keepformat to true has eliminated these errors for me. It may be worthwhile examining other sql tasks in ant to see if they would benefit from this setting (it is already included in many of the existing sql tasks).