string: fix isNumber accepting - as valid number

hyprwm · Jun 15, 2024 · ea8fd1d · ea8fd1d
1 parent 8e10e06
commit ea8fd1d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/string/String.cpp b/src/string/String.cpp
@@ -51,7 +51,7 @@ bool Hyprutils::String::isNumber(const std::string& str, bool allowfloat) {
         }
     }
 
-    if (str.back() == '.')
+    if (!isdigit(str.back()))
         return false;
 
     return true;

diff --git a/tests/string.cpp b/tests/string.cpp
@@ -19,6 +19,7 @@ int main(int argc, char** argv, char** envp) {
     EXPECT(isNumber("---3423--432s"), false);
     EXPECT(isNumber("1s"), false);
     EXPECT(isNumber(""), false);
+    EXPECT(isNumber("-"), false);
     EXPECT(isNumber("--0"), false);
     EXPECT(isNumber("abc"), false);
     EXPECT(isNumber("0.0", true), true);