Send flag notification emails to moderators #9116
Conversation
seanh
force-pushed
the
send-flag-notification-emails-to-moderators
branch
from
77ae1a8
to
5f632e2
Compare
| @requires(authenticated_user, group_found) | ||
| def group_created_by_user(identity, context): | ||
| return context.group.creator and context.group.creator.id == identity.user.id |
There was a problem hiding this comment.
No longer used: being a group's creator no longer grants you any privileges.
Send flag notification emails to all of a group's moderators rather than just to the group's creator. Also allow all moderators to moderate (hide) flagged annotations, not just the creator.
seanh
force-pushed
the
send-flag-notification-emails-to-moderators
branch
from
5f632e2
to
b88d390
Compare
| memberships = group_members_service.get( | ||
| annotation.group, roles=list(GROUP_MODERATE_PREDICATES.keys()) | ||
| ) |
There was a problem hiding this comment.
I originally wanted this to go through the permissions system to get the list of users who have the Permission.Group.MODERATE permission in the context of this annotation's group: create a context object for the group, then for each member create an identity object and call identity_permits(identity, context, Permission.Group.MODERATE) to see if that member should get a moderation email. But there are two problems with that:
- We'd have to fetch all the group's members from the DB and iterate over them, doing a permissions check for each individual member to find out which ones to email
- Creating an identity for a user with
Identity.from_models(user)iterates over all the user's memberships (of all groups that the user is a member of). So we don't want to iterate over all a group's memberships callingIdentity.from_models(membership.user)for each of them
I think we want to avoid a solution that scales poorly as the number of plain members (not even moderators) of the group increases, so I think the solution in this PR that duplicates some logic is better.
There was a problem hiding this comment.
The list() is actually need to get an assert_called_once_with() in the tests to pass.
Send flag notification emails to all of a group's moderators rather than just to the group's creator.
Also allow all moderators to moderate (hide) flagged annotations, not just the creator.