Allow custom toggle title to be passed to MenuItems #6753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6753 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 270 270
Lines 10196 10200 +4
Branches 2433 2437 +4
=======================================
+ Hits 10138 10142 +4
Misses 58 58 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
submenu-toggle-title
branch
from
72187cb to
0b9e277
Compare
acelaya
commented
Jan 7, 2025
Comment on lines
+238
to
+241
| submenuToggleTitle ?? | ||
| (typeof label === 'string' | ||
| ? `Show actions for ${label}` | ||
| : `Toggle submenu`) |
There was a problem hiding this comment.
For backwards compatibility, we still resolve the title `Show actions for ${label}` when submenuToggleTitle is not provided, but only if label is a string.
acelaya
force-pushed
the
submenu-toggle-title
branch
from
0b9e277 to
a00e66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at fixing #6740.
As opposed to #6752, this PR keep MenuItem's
labelasComponentChildren, but adds a new optionalsubmenuToggleTitlestring prop which is used as the submenu toggle title, if there's a submenu at all.For backwards compatibility, if this prop is not provided, we still try to infer the title by templating
`Show actions for ${label}`, but only iflabelis a string, to avoid the bug that we are trying to fix to still happen accidentally.