Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging instead of backtrace for IPv6-addresses when unsupported #834

Conversation

ArneBab
Copy link
Contributor

@ArneBab ArneBab commented Apr 19, 2023

Throwing backtraces is needlessly expensive and spams the log with no additional gain.

Throwing backtraces is needlessly expensive and spams the log with no
additional gain.
@ArneBab ArneBab force-pushed the ipv6--log-instead-of-backtrace-with-unsupported-address-type-on-java-17-or-newer branch from 0857c38 to 80cbda8 Compare September 9, 2023 03:20
Copy link
Contributor

@bertm bertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ArneBab ArneBab merged commit 34a70e9 into next Feb 15, 2024
1 check passed
@ArneBab
Copy link
Contributor Author

ArneBab commented Feb 15, 2024

@bertm merged — thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants