Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MultiValueTable #829
Improve MultiValueTable #829
Changes from 1 commit
a877b23
573cee3
00f9ef2
0525735
ab7e17c
a9aae2d
0a32278
7db50fd
3bfbc44
c6f8d7f
3b5523d
2eef2a0
7f8ef91
2d85389
5573a5f
c48a27b
98e1cf7
7fed29f
2217f1f
f7d34e3
117dad4
e7ff0e4
b79a2a0
36cd30b
643cbee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, most of these tests are pretty horrible. 🙁 Coverage is pretty good, though, so they’ll do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that there is no need to check such trivial places?
Or those preparations of test collections are not very clear?