M3u add parsing of forwarded header wip #716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess this could now use a merge or a rebase, whichever you prefer. :) |
|
Please don't mix formatting changes with code changes... it makes reviewing PRs such as this one very difficult |
ArneBab
force-pushed
the
m3u-add-parsing-of-forwarded-header-wip
branch
2 times, most recently
from
f346f45 to
6ee70b1
Compare
|
First step: rebased and whitespace and imports cleaned up. |
ArneBab
force-pushed
the
m3u-add-parsing-of-forwarded-header-wip
branch
6 times, most recently
from
0d4814d to
92c4424
Compare
|
Second step: more cleanup and some force pushing, because it should now be much easier to check. |
ArneBab
force-pushed
the
m3u-add-parsing-of-forwarded-header-wip
branch
4 times, most recently
from
eecfda3 to
cbfac8a
Compare
ArneBab
force-pushed
the
m3u-add-parsing-of-forwarded-header-wip
branch
from
cbfac8a to
6d51184
Compare
|
@Bombe I added tests and fixed the case sensitivity (keys must be insensitive). But this isn’t tested in production, yet. |
|
Hmm, according to RFC 7239 there can be multiple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only merge after m3u is merged!
WIP, because parsing that header directly needs somewhat careful checking.