Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #44

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Update README.md #44

merged 3 commits into from
Nov 28, 2024

Conversation

jlacko
Copy link
Contributor

@jlacko jlacko commented Nov 27, 2024

I suggest an update in the readme - from http >> https - the original image was broken

no real functionality, just a presentation issue...

http >> https - the original image was broken
@mpadge
Copy link
Member

mpadge commented Nov 27, 2024

Thanks! Could you actually do this via:

urlchecker::url_update()

That will then update both files, and ensure everything is fixed.

@jlacko
Copy link
Contributor Author

jlacko commented Nov 27, 2024

thank you for teaching me a new package! done with urlchecker

@jlacko
Copy link
Contributor Author

jlacko commented Nov 27, 2024

on second thought: the urlchecker seems to be perhaps too aggressive - it actually broke the codecov badge (corrected now)

@mpadge mpadge merged commit 815438f into hypertidy:main Nov 28, 2024
7 checks passed
@mpadge
Copy link
Member

mpadge commented Nov 28, 2024

Thank you very much @jlacko, you'll added to the allcontributions section of readme in next commit, which'll be linked below ...

mpadge added a commit that referenced this pull request Nov 28, 2024
@jlacko jlacko deleted the patch-1 branch November 28, 2024 08:44
@jlacko
Copy link
Contributor Author

jlacko commented Nov 28, 2024

Thank you, that is very kind (perhaps even too kind, given the minor update). But thanks!

@mpadge
Copy link
Member

mpadge commented Nov 28, 2024

Hey, it's all "allcontributors". Plus I just published this blog post, and this is just me doing what I say there 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants