Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates CL contracts to use event based approach + Drop did:indy2 #11

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Updates CL contracts to use event based approach + Drop did:indy2 #11

merged 5 commits into from
Jan 30, 2024

Conversation

Artemkaaas
Copy link
Contributor

The PR contains the following changes:

  • Update SchemaRegistry and CrdentialDefinitionRegistry smart contracts to store data in transaction event logs instead of storage
  • Endorsement methods for sending schema and credDef
  • Update VDR and wrapper methods to match new smart contracts API and resolution flow
  • Drop did:indy2 method in favour of using did:ethr
  • Updated affected documentation

@Artemkaaas Artemkaaas force-pushed the feature/cl-on-events branch from 86c7b06 to 54c9400 Compare January 30, 2024 10:19
@Artemkaaas Artemkaaas force-pushed the feature/cl-on-events branch from 54c9400 to ef330f6 Compare January 30, 2024 10:26
@Artemkaaas
Documentation clean up
dbf6e7c 
Signed-off-by: artem.ivanov <[email protected]>
Toktar
Toktar reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Toktar Toktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this big design change!
No requests for change really, just a few questions.
And it will be nice if we can extend tests a bit according to new changes. Not urgent because updated demos cover most cases.

docs/design/cl-registry.md Show resolved Hide resolved
docs/design/cl-registry.md Show resolved Hide resolved
docs/design/endorsement.md Outdated Show resolved Hide resolved
smart_contracts/contracts/cl/CLRegistry.sol Show resolved Hide resolved
smart_contracts/contracts/cl/CredentialDefinitionRegistry.sol Outdated Show resolved Hide resolved
vdr/src/client/client.rs Show resolved Hide resolved
vdr/wrappers/python/indy2_vdr/indy2_vdr.py Outdated Show resolved Hide resolved
@Artemkaaas Artemkaaas force-pushed the feature/cl-on-events branch from 7ea8326 to bee9ce7 Compare January 30, 2024 14:10
@Artemkaaas Artemkaaas force-pushed the feature/cl-on-events branch from bee9ce7 to 4952bd3 Compare January 30, 2024 14:25
@Artemkaaas Artemkaaas force-pushed the feature/cl-on-events branch from 4f02408 to 9bb3ad1 Compare January 30, 2024 14:59
@Artemkaaas Artemkaaas merged commit 7abeac9 into hyperledger:main Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toktar Toktar Toktar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artemkaaas @Toktar