Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EOFCREATE memory code #7979

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Dec 3, 2024

PR description

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Copy link
Contributor Author

shemnon commented Dec 3, 2024

tests are here - ethereum/execution-spec-tests#989

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Switch to longs so EOFCREATE can handle gigagas sized transactions.

Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants