Round change upon f+1 RC messages (experimental option) #7838
+342
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2024 14:45
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
matthew1001
approved these changes
Dec 2, 2024
consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftHelpers.java
Outdated
Show resolved
Hide resolved
...sts/tests/src/test/java/org/hyperledger/besu/tests/acceptance/bftsoak/BftMiningSoakTest.java
Outdated
Show resolved
Hide resolved
|
I forgot about this, just having a look now. Hopefully won't take me log to get through it. |
Co-authored-by: Matt Whitehead <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
pullurib
force-pushed
the
qbft-rc-quorum
branch
from
083956e to
468e194
Compare
added 3 commits
December 3, 2024 15:43
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
jframe
reviewed
Dec 4, 2024
consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftHelpers.java
Outdated
Show resolved
Hide resolved
| doRoundChange(qbftRound.getRoundIdentifier().getRoundNumber() + 1); | ||
| } | ||
|
|
||
| private synchronized void doRoundChange(final int newRoundNumber) { |
There was a problem hiding this comment.
Why does this need to be synchronized?
There was a problem hiding this comment.
this is called by two threads one handling round timer expiry and the other handling RC payload (upon f+1 RC quorum) . So made it synchronized as there's no scope of IO blocking or no scope for deadlock without calls to other synchronized methods. Can finegrain it if needed
...ain/java/org/hyperledger/besu/consensus/qbft/statemachine/QbftBlockHeightManagerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Plan going ahead
Next release
--Xqbft-enable-early-round-change = false
--Xqbft-enable-early-round-change = true
Besu 25.6.0
Remove --Xqbft-enable-early-round-change (NOT make it --qbft-enable-early-round-change)
Fixed Issue(s)
#1822