Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preimage store #7800

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Oct 23, 2024

PR description

Draft status PR for preimage store.

Highlights include:

  • cli feature param
  • forest persisted or in-memory preimages store
  • bonsai persisted, in-memory limited, in-memory unbounded preimage store
  • refactoring, removing of reference test specific behavior
  • incorporation into worldstatekeyvaluestorage classes

📝 Draft status,
✅ reference tests passing

still outstanding TODOs:

  • make option a selection of none, in-memory limited, and persistent
  • specific unit test coverage for preImage implementations
  • optimizations for slotkey preimages

Fixed Issue(s)

fixes #7796

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte force-pushed the feature/preimage-store branch 14 times, most recently from 6f04716 to 84cf9c7 Compare October 25, 2024 18:10
@garyschulte garyschulte force-pushed the feature/preimage-store branch 4 times, most recently from c765ebb to ccbbc42 Compare November 12, 2024 09:47
@garyschulte garyschulte force-pushed the feature/preimage-store branch from 476fdcf to 562161b Compare November 19, 2024 17:28
@@ -157,6 +157,11 @@ public boolean isClosed() {
return closed.get();
}

@Override
public boolean isPersistent() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of the isPersistent() methods are no longer necessary for this implementation. it is useful information to have, but it doesn't serve a purpose currently. probably should remove

@garyschulte garyschulte force-pushed the feature/preimage-store branch from 562161b to 7df1bae Compare December 11, 2024 18:12
@garyschulte garyschulte force-pushed the feature/preimage-store branch from 7df1bae to 1161f09 Compare December 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Implement hash preimage storage persistence
1 participant