feat(testnet): test-genesis as a default, env vars for client config #5283
Conversation
s8sato
requested review from
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
s8sato
added
the
config-changes
| "name": "CanManagePeers", | ||
| "payload": null | ||
| }, | ||
| "destination": "ed0120CE7FA46C9DCE7EA4B125E2E36BDB63EA33073E7590AC92816AE1E861B7048B03@wonderland" |
There was a problem hiding this comment.
Alice's private key is actually public for now, so this key pair needs to be replaced in secret Since Alice's private key is exposed, another admin should replace Alice. Otherwise anyone can act as admin Alice to un/register peers, reset parameters, un/register domains, update to arbitrary executor, etc. @BAStos525
There was a problem hiding this comment.
Can we redefine Alice's keys pair from client config as env vars? I guess so
There was a problem hiding this comment.
Yes, but Alice's public key should be consistent with genesis. If you share it with me I'll update genesis in this PR
There was a problem hiding this comment.
Just ACCOUNT_PUBLIC_KEY and ACCOUNT_PRIVATE_KEY env vars export?
There was a problem hiding this comment.
Yes, and replace ed0120..8B03 with that public key in genesis.json. I can update the default genesis in another PR, if you want to. It's a simple replacement of the public key
There was a problem hiding this comment.
Let's think of it as replacing Alice with another administrator, not replacing Alice's keys. Done by #5284
s8sato
force-pushed
the
testnet/client_config_env
branch
from
c138915 to
b291d80
Compare
Signed-off-by: Shunkichi Sato <[email protected]>
…enesis Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
s8sato
force-pushed
the
testnet/client_config_env
branch
from
b291d80 to
e2e6581
Compare
s8sato
merged commit e434186
into
hyperledger-iroha:testnet/2.0.0-rc.1
Context
In testnet,