Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add FeeHook and Swell to ezEth #4935

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Add FeeHook and Swell to ezEth #4935

wants to merge 10 commits into from

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Dec 2, 2024

Description

Drive-by changes

Related issues

Backward compatibility

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7bfcfd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (79f8197) to head (7bfcfd3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4935   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

ltyu
ltyu commented Dec 3, 2024
View reviewed changes
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
address: '0x7a0f4a8672f603e0c12468551db03f3956d10910', // TODO: NOT READY
alias: 'Luganodes',
},
{ address: '0xb6b9b4bd4eb6eb3aef5e9826e7f8b8455947f67c', alias: 'Renzo' },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source: https://t.me/c/2192542084/1506

@ltyu ltyu force-pushed the ltyu/ezEth-swell-feeHook branch from 4c0ce06 to 1fdd80b Compare December 3, 2024 16:23
@ltyu ltyu force-pushed the ltyu/ezEth-swell-feeHook branch from 1fdd80b to dd66c18 Compare December 3, 2024 16:24
ltyu
ltyu commented Dec 6, 2024
View reviewed changes
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
@@ -41,6 +51,7 @@ const xERC20: Record<(typeof chainsToDeploy)[number], string> = {
zircuit: '0x2416092f143378750bb29b79eD961ab195CcEea5',
taiko: '0x2416092f143378750bb29b79eD961ab195CcEea5',
sei: '0x6DCfbF4729890043DFd34A93A2694E5303BA2703', // redEth
swell: '0x2416092f143378750bb29b79eD961ab195CcEea5',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source: https://t.me/c/2192542084/1576

ltyu
ltyu commented Dec 6, 2024
View reviewed changes
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
@@ -179,6 +200,7 @@ export const ezEthSafes: Record<string, string> = {
zircuit: '0x8410927C286A38883BC23721e640F31D3E3E79F8',
taiko: '0x8410927C286A38883BC23721e640F31D3E3E79F8',
sei: '0x0e60fd361fF5b90088e1782e6b21A7D177d462C5',
swell: '0x435E8c9652Da151292F3981bbf663EBEB6668501',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source: https://t.me/c/2192542084/1534

ltyu
ltyu commented Dec 6, 2024
View reviewed changes
typescript/infra/config/environments/mainnet3/warp/configGetters/getRenzoEZETHWarpConfig.ts
threshold: 1,
validators: [
{
address: '0x9eadf9217be22d9878e0e464727a2176d5c69ff8',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-06 at 4 01 19 PM

@ltyu ltyu marked this pull request as ready for review December 6, 2024 22:30
@ltyu ltyu enabled auto-merge December 6, 2024 22:30
@ltyu ltyu disabled auto-merge December 6, 2024 22:31
paulbalaji
paulbalaji reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you merged the change to registry? need to update the .registryrc

AssertionError: Warp ID EZETH/arbitrum-base-blast-bsc-ethereum-fraxtal-linea-mode-optimism-sei-swell-taiko-zircuit not in registry, the .registryrc or your local registry may be out of date: expected null not to be null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalaji paulbalaji paulbalaji left review comments

@xeno097 xeno097 xeno097 approved these changes

@yorhodes yorhodes yorhodes approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@Mo-Hussain Mo-Hussain Awaiting requested review from Mo-Hussain Mo-Hussain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltyu @yorhodes @paulbalaji @xeno097