-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(warpConfig): Fix LUMIA/bsc-ethereum-lumia warp config #4928
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4928 +/- ##
=======================================
Coverage 77.40% 77.40%
=======================================
Files 103 103
Lines 2111 2111
Branches 195 195
=======================================
Hits 1634 1634
Misses 456 456
Partials 21 21
|
@@ -38,7 +38,7 @@ export const getEthereumBscLUMIAWarpConfig = async ( | |||
mailbox: '0x3a867fCfFeC2B790970eeBDC9023E75B0a172aa7', | |||
proxyAdmin: { | |||
owner: owner, | |||
address: '0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorhodes - Wanted to confirm that you agree that this was a misconfiguration. 0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D
is the Hyperlane proxyAdmin on Lumia see https://github.com/hyperlane-xyz/hyperlane-registry/pull/348/files#diff-db9320e038aa13af3ce7b3297aab2dcc286e31c2bb4d3f656a2e91d4d5194e0cL14
Description
Drive-by changes
Testing
Manual