Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warpConfig): Fix LUMIA/bsc-ethereum-lumia warp config #4928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mo-Hussain
Copy link
Contributor

Description

  • Fix LUMIA/bsc-ethereum-lumia warp config, proxyAdmin address was incorrectly set to the AW proxyAdmin in Lumia
  • Recent bug fix in checker has surfaced this issue

Drive-by changes

  • Fix bug with ownership check when proxyAdmin is not set in config

Testing

Manual

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 68bcb30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Mo-Hussain Mo-Hussain self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (665a7b8) to head (68bcb30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4928   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files         103      103           
  Lines        2111     2111           
  Branches      195      195           
=======================================
  Hits         1634     1634           
  Misses        456      456           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 78.91% <ø> (ø)

@@ -38,7 +38,7 @@ export const getEthereumBscLUMIAWarpConfig = async (
mailbox: '0x3a867fCfFeC2B790970eeBDC9023E75B0a172aa7',
proxyAdmin: {
owner: owner,
address: '0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D',
Copy link
Contributor Author

@Mo-Hussain Mo-Hussain Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorhodes - Wanted to confirm that you agree that this was a misconfiguration. 0xeA87ae93Fa0019a82A727bfd3eBd1cFCa8f64f1D is the Hyperlane proxyAdmin on Lumia see https://github.com/hyperlane-xyz/hyperlane-registry/pull/348/files#diff-db9320e038aa13af3ce7b3297aab2dcc286e31c2bb4d3f656a2e91d4d5194e0cL14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants