feat: zksync support #4725
feat: zksync support #4725
Conversation
…ocolSigner implementation for flexible cross-chain signer configuration and management
| return false; | ||
| } | ||
|
|
||
| if (input.address === ethers.constants.AddressZero) return false; |
There was a problem hiding this comment.
see isZeroishAddress in the utils package
| import { ChainMap, ChainName } from '../../types.js'; | ||
|
|
||
| import { ContractVerificationInput } from './types.js'; | ||
|
|
||
| const { Interface } = await import('@ethersproject/abi'); |
There was a problem hiding this comment.
Why are you doing a dynamic import of this? Instead, import it directly from the ethers package like other imports above
| @@ -99,12 +100,12 @@ export class MultiProtocolProvider< | |||
| const providers = objMap( | |||
| this.providers, | |||
| (_, typeToProviders) => typeToProviders[ProviderType.EthersV5]?.provider, | |||
| ) as ChainMap<EthersV5Provider['provider'] | undefined>; | |||
| ) as ChainMap<ZKSyncProvider['provider'] | undefined>; | |||
There was a problem hiding this comment.
Similar to the concern I expressed above around the Wallet class, I disagree that ZKSyncProviders should replace Ethers V5 providers as the default provider type here
There was a problem hiding this comment.
You are right, this should not be here. Resolved
| if (!provider) return signer; | ||
|
|
||
| // Handle ZKSync provider separately | ||
| if (signer instanceof ZKSyncWallet) { |
There was a problem hiding this comment.
Using instanceof this way has pitfalls and is generally a code smell. Is there a tangible property on the signer you can check instead?
There was a problem hiding this comment.
Your comment on removing ZKSyncWallet form ChainMap helped me resolve this. No longer need to check for instance of
| const metadata = this.tryGetChainMetadata(chainNameOrId); | ||
| if (!metadata) { | ||
| throw new Error('Chain metadata not found!'); |
There was a problem hiding this comment.
Just use this.getChainMetadata(chainNameOrId); and it'll throw if if doesn't find it
| // Kept for backwards compatibility | ||
| export function defaultZKProviderBuilder( |
There was a problem hiding this comment.
Why would we need this for backwards compat when it doesn't currently exist? You can remove this
There was a problem hiding this comment.
we use it in MultiProvider, will remove this comment
| @@ -43,7 +55,7 @@ export interface MultiProviderOptions { | |||
| export class MultiProvider<MetaExt = {}> extends ChainMetadataManager<MetaExt> { | |||
| readonly providers: ChainMap<Provider>; | |||
| readonly providerBuilder: ProviderBuilderFn<Provider>; | |||
| signers: ChainMap<Signer>; | |||
| signers: ChainMap<ZKSyncWallet | Signer>; | |||
There was a problem hiding this comment.
So ZKSyncWallet doesn't implement the Signer interface? I'd expect that it would since an Ethers.js Wallet does implement it
There was a problem hiding this comment.
For types we can remove both ZKSyncWallet and ZKSyncProvider from ChainMap and type Provider ... but we need to be mindful that MultiProvider is also used for deploying contracts (& gas estimation...), and for that we use ZKSyncDeployer class, which strictly requires that the type of signer is ZKSyncWallet [extends Wallet base]. Meaning that type casting to ZKSyncWallet will still be required down in the code. We need to keep this in mind.
…nc-signer-strategy
|
I was trying this feature and I caught this error while deploying warp contracts: |
Description
This PR introduces a series of changes aimed at enhancing zkSync support within the codebase. Key updates include the addition of the zksolc compiler for zkSync, integration of contract artifacts, CLI automation for core deployment, and compatibility adjustments in tests for the zkSync environment. It also includes improvements in contract verification on zkSync explorer and handling gas limits for zkSync deployments.
Drive-by changes
Related issues
No related issue
Backward compatibility
Yes
Testing
Manual testing and some automated tests were performed, including end-to-end tests on zkSync for warp read and apply functionalities.