Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify contracts deployed from infra #3243

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Feb 9, 2024

resolves https://github.com/hyperlane-xyz/issues/issues/1033

  • use standard input json instead of flattened source in verify script
  • remove flatten script
  • unify hardhat config formats
  • drive-by lint fix
  • drive-by helloworld verification.json fix

Follow-up:

Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 69e1cbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji changed the title feat: verify contracts using artifacts feat: verify contracts deployed from infra Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #3243 (69e1cbb) into main (e6e7de8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3243   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@paulbalaji paulbalaji force-pushed the feat/verify-contracts branch from b7e3559 to f0640e7 Compare February 12, 2024 10:08
@paulbalaji paulbalaji marked this pull request as ready for review February 12, 2024 11:04
@paulbalaji paulbalaji force-pushed the feat/verify-contracts branch from d0c5b8e to 851a035 Compare February 12, 2024 11:14
solidity/flatten.sh Outdated Show resolved Hide resolved
typescript/sdk/src/metadata/ChainMetadataManager.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/verify.ts Outdated Show resolved Hide resolved
typescript/helloworld/hardhat.config.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/deploy.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/verify.ts Outdated Show resolved Hide resolved
@paulbalaji paulbalaji force-pushed the feat/verify-contracts branch from 7c42a80 to 7c461c2 Compare February 13, 2024 10:56
@paulbalaji paulbalaji force-pushed the feat/verify-contracts branch 2 times, most recently from d8b039e to 3cb6c29 Compare February 13, 2024 13:31
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the SDK portion. Not very familiar with the infra artifact management so you may want another approval for that. Left some optional comments but mostly lgtm

@paulbalaji paulbalaji force-pushed the feat/verify-contracts branch 2 times, most recently from e8985c6 to 25d91a2 Compare February 14, 2024 18:23
@paulbalaji paulbalaji enabled auto-merge (squash) February 21, 2024 12:12
@paulbalaji paulbalaji merged commit c47ebdb into main Feb 21, 2024
30 checks passed
@paulbalaji paulbalaji deleted the feat/verify-contracts branch February 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants