feat: use local artifacts to fetch keys for the key-funder #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description <!-- What's included in this PR? --> ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
aroralanuk
requested review from
tkporter,
nambrot,
yorhodes and
jmrossy
as code owners
|
Base automatically changed from
kunal/rm-create-key-circular-dependency
to
main
February 7, 2024 15:31
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
aroralanuk
changed the title
yorhodes
reviewed
Feb 8, 2024
Co-authored-by: Yorke Rhodes <[email protected]>
yorhodes
approved these changes
Feb 12, 2024
…' into kunal/key-funder-local-artifacts
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
…-xyz#3173) ### Description Motivation - supports maintaining the source of truth for account keys in version control - key-funder now fetches relayer,kathy keys from local artifacts instead of gcp secrets - local artifacts schema located here: hyperlane-xyz#3159 - changing type of key from `BaseCloudAgentKey` to `BaseAgentKey` ### Drive-by changes - restricting rolesToFund to `FundableRole` type which is just Kathy,Relayer which prevent the person running the script locally to accidentally fund validator keys. ### Related issues - fixes hyperlane-xyz/issues#888 ### Backward compatibility Yes ### Testing Manual --------- Co-authored-by: Yorke Rhodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation - supports maintaining the source of truth for account keys in version control
BaseCloudAgentKeytoBaseAgentKeyDrive-by changes
FundableRoletype which is just Kathy,Relayer which prevent the person running the script locally to accidentally fund validator keys.Related issues
Backward compatibility
Yes
Testing
Manual