fix: failing ci tests for SmartProvider and OpStackIsm.t.sol
#3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
requested review from
yorhodes,
jmrossy and
tkporter
as code owners
|
aroralanuk
changed the title
and OpStackIsm.t.solSmartProvider and OpStackIsm.t.sol`
aroralanuk
changed the title
SmartProvider and OpStackIsm.t.sol`SmartProvider and OpStackIsm.t.sol
yorhodes
approved these changes
Jan 12, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
- Coverage 67.51% 0.00% -67.52%
==========================================
Files 101 1 -100
Lines 1022 16 -1006
Branches 106 0 -106
==========================================
- Hits 690 0 -690
+ Misses 292 16 -276
+ Partials 40 0 -40
|
jmrossy
added a commit
that referenced
this pull request
Jan 13, 2024
### Description Remove hard-coding of min block number and topic1 value. ### Drive-by changes Add convenience `isAddress` util function ### Related issues #3148 ### Backward compatibility Yes
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
…erlane-xyz#3148) ### Description - Problem: OpStackIsm.t.sol was failing because of very stale block number for fork Fix: Excluding foundry fork testing from CI and updating block number - Problem: SmartProvider getLogs tests failing because the the results end up being an empty list and getConfirmations results a smaller number of confirmations than expected (712 vs 1705184) fix: excluded from ci ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Manual
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
### Description Remove hard-coding of min block number and topic1 value. ### Drive-by changes Add convenience `isAddress` util function ### Related issues hyperlane-xyz#3148 ### Backward compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: OpStackIsm.t.sol was failing because of very stale block number for fork
Fix: Excluding foundry fork testing from CI and updating block number
Problem: SmartProvider getLogs tests failing because the the results end up being an empty list and getConfirmations results a smaller number of confirmations than expected (712 vs 1705184)
fix: excluded from ci
Drive-by changes
None
Related issues
None
Backward compatibility
Yes
Testing
Manual