Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default std feature #637

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: add default std feature #637

merged 1 commit into from
Nov 13, 2023

Conversation

seanmonstar
Copy link
Member

cc #563

@seanmonstar seanmonstar mentioned this pull request Nov 10, 2023
Open
@seanmonstar seanmonstar added the B-breaking Blocked: breaking change. This requires a breaking change. label Nov 10, 2023
@seanmonstar seanmonstar added this to the 1.0 milestone Nov 10, 2023
algesten
algesten approved these changes Nov 10, 2023
View reviewed changes
Copy link

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seanmonstar
Copy link
Member Author

I admit I have no clue why the compilation fails so completely...

seanmonstar
seanmonstar commented Nov 13, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit c51f40f into master Nov 13, 2023
6 checks passed
@seanmonstar seanmonstar deleted the feature-std branch November 13, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
B-breaking Blocked: breaking change. This requires a breaking change.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seanmonstar @algesten @LucioFranco