Merge pull request #55 from huangzhhui/fix-version-validate

Fix version validate error when the latest version is not a numeric
hyperf · Oct 11, 2022 · ea6c845 · ea6c845
2 parents b8b1e9c + f9a7b04
commit ea6c845
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/app/DownloadHandler/AbstractDownloadHandler.php b/src/app/DownloadHandler/AbstractDownloadHandler.php
@@ -211,6 +211,8 @@ protected function latestVersionCheck(string $currentVersion, Definition $defini
             return;
         }
         $latestVersion = $this->versions($definition->getPkgName())[0] ?? '';
+        // Trim v prefix
+        $latestVersion = ltrim($latestVersion, 'v');
         if ($latestVersion && version_compare($currentVersion, $latestVersion, '>=')) {
             throw new BoxException(sprintf('Your %s version %s is latest, no need to update, add `--reinstall` or `-r` option to force reinstall the package.', $definition->getPkgName(), $currentVersion));
         }