Merge pull request #26 from huangzhhui/master

Add exception for empty download url

src/app/DownloadHandler/AbstractDownloadHandler.php

@@ -51,19 +51,22 @@ protected function fetchDownloadUrlFromGithubRelease(string $assetName, string $
         $release = $this->githubClient->getRelease($fullRepo, $version);
         $url = null;
         foreach ($release['assets'] ?? [] as $asset) {
-            if ($asset['name'] === $assetName) {
+            if ($asset['name'] === $assetName && $asset['browser_download_url']) {
                 $url = $asset['browser_download_url'];
             }
         }
         return $url;
     }
 
     protected function download(
-        string $url,
+        ?string $url,
         string $savePath,
         int $permissions,
         string $renameTo = ''
     ): SplFileInfo {
+        if (! $url) {
+            throw new \RuntimeException('Download url is empty, maybe the url parse failed.');
+        }
         $this->logger->info(sprintf('Downloading %s', $url));
         if (str_ends_with($savePath, '/')) {
             $explodedUrl = explode('/', $url);