Add model with GLVQ classifier #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeheddes
approved these changes
Feb 13, 2023
| ) | ||
|
|
||
| # Training loop | ||
| trainer.fit(self.classifier, train_ld) |
There was a problem hiding this comment.
I got an error when running this example:
File "../site-packages/prototorch/models/abstract.py", line 189, in log_acc
accuracy = torchmetrics.functional.accuracy(preds.int(), targets.int())
TypeError: accuracy() missing 1 required positional argument: 'task'
It looks like prototorch_models is relying on an older version of torchmetrics which recently changed their API design. Downgrading to torchmetrics=0.10.3 worked for me.
|
Thank you @denkle for another great contribution! |
|
Hi, just wanted to ask if you had time to look into this yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is working properly though the accuracy is lower than expected based in the results reported in the paper.