$mol_offline refactor, disable cache on page reload via dev server #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nin--jin
reviewed
Oct 26, 2024
nin--jin
reviewed
Oct 26, 2024
nin--jin
reviewed
Oct 26, 2024
nin--jin
reviewed
Oct 26, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 27, 2024
nin--jin
reviewed
Oct 31, 2024
nin--jin
reviewed
Oct 31, 2024
nin--jin
reviewed
Nov 5, 2024
fetch/fetch.ts
Outdated
Comment on lines
83
to
85
| export function $mol_fetch_request_clone(this: typeof $, original: Request, options?: RequestInit) { | ||
| return new Request(original, options) | ||
| } |
There was a problem hiding this comment.
Хотя, сделать и над реквестом обёртку возможно не плохая идея. Есть ил ещё какая полезная функциональность для реквестов помимо клонирования?
nin--jin
reviewed
Nov 5, 2024
fetch/fetch.ts
Outdated
| export function $mol_fetch_request_clone(this: typeof $, original: Request, options?: RequestInit) { | ||
| return new Request(original, options) | ||
| } | ||
| $.$mol_fetch_request_clone = $mol_wire_sync($).$mol_fetch_request_clone |
There was a problem hiding this comment.
Опять у тебя простое клонирование реквеста тянет за собой реактивность.
There was a problem hiding this comment.
А какое отношение реквест вообще имеет к фетчу?
nin--jin
reviewed
Nov 5, 2024
notify/notify.ts
Outdated
| } | ||
|
|
||
| static show( info: $mol_notify_info ) { | ||
| this.$.$mol_service_worker.send(info) |
There was a problem hiding this comment.
send посылает любые сообщения? Если так, то одного $mol_notify_info тут мало. Если только нотификации, то send - не удачное название.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.